Skip to content

feat: Add generic database connection mechanism#754

Open
sbernauer wants to merge 25 commits intomainfrom
feat/generic-database-connection
Open

feat: Add generic database connection mechanism#754
sbernauer wants to merge 25 commits intomainfrom
feat/generic-database-connection

Conversation

@sbernauer
Copy link
Copy Markdown
Member

@sbernauer sbernauer commented Mar 4, 2026 •
edited by adwk67
Loading

Description

Part of stackabletech/issues#238

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

sbernauer and others added 7 commits March 3, 2026 10:51
@sbernauer
feat: Implement generic database connection
f6efcbe
@sbernauer
fix: Add to Pod template as well
b035622
@sbernauer
Bump op-rs
a67081b
@sbernauer
Fix tests
cfb0481
@sbernauer @adwk67
Update kuttl tests
c00b629 
Co-authored-by: Andrew Kenworthy <andrew.kenworthy@stackable.tech>
@sbernauer @adwk67
Update docs
30c83e2 
Co-authored-by: Andrew Kenworthy <andrew.kenworthy@stackable.tech>
@sbernauer
Further update docs
ba6c88d
@sbernauer sbernauer mentioned this pull request Mar 4, 2026
Open
20 tasks
sbernauer
sbernauer commented Mar 4, 2026
View reviewed changes
Comment thread rust/operator-binary/src/crd/mod.rs
@sbernauer sbernauer marked this pull request as ready for review March 4, 2026 14:29
sbernauer
sbernauer commented Mar 4, 2026
View reviewed changes
Comment thread rust/operator-binary/src/airflow_controller.rs
@sbernauer sbernauer mentioned this pull request Mar 18, 2026
Closed
13 tasks
sbernauer
sbernauer commented Mar 19, 2026
View reviewed changes
Comment thread extra/crds.yaml Outdated
@adwk67 adwk67 mentioned this pull request Apr 1, 2026
Closed
20 tasks
@sbernauer sbernauer self-assigned this Apr 20, 2026
@sbernauer sbernauer moved this to Development: In Progress in Stackable Engineering Apr 20, 2026
@sbernauer
Copy link
Copy Markdown
Member Author

sbernauer commented Apr 21, 2026

Started https://testing.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/airflow-operator-it-custom/91/

@sbernauer sbernauer moved this from Development: In Progress to Development: Waiting for Review in Stackable Engineering Apr 21, 2026
@sbernauer sbernauer requested review from adwk67 and maltesander April 21, 2026 09:20
@sbernauer sbernauer added release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action. scheduled-for/26.7.0 labels Apr 21, 2026
@adwk67 adwk67 moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Apr 21, 2026
adwk67
adwk67 requested changes Apr 21, 2026
View reviewed changes
Comment thread docs/modules/airflow/pages/getting_started/first_steps.adoc Outdated
Comment thread CHANGELOG.md
- BREAKING: `configOverrides` now only accepts the known config file `webserver_config.py`. Previously, arbitrary file names were silently accepted and ignored ([#775]).
- Bump `stackable-operator` to 0.110.1, kube to 3.1.0, and snafu to 0.9 ([#775]).
- BREAKING: Rename `EXPERIMENTAL_FILE_HEADER` and `EXPERIMENTAL_FILE_FOOTER` in `webserver_config.py` for arbitrary python code to `FILE_HEADER` and `FILE_FOOTER` ([#775], [#777]).
- BREAKING: The `.clusterConfig.credentialsSecret` field has been renamed to `.clusterConfig.credentialsSecretName` for consistency ([#754]).
Copy link
Copy Markdown
Member

@adwk67 adwk67 Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missed in couple of places: tests/templates/kuttl/overrides/11-assert.yaml, as well as deploy/config-spec/properties.yaml and deploy/helm/airflow-operator/configs/properties.yaml

Copy link
Copy Markdown
Member Author

@sbernauer sbernauer Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, adopted my regex and fixed them in 22a55af

Copy link
Copy Markdown
Member

@adwk67 adwk67 Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the properties-config well enough :) Do we no longer need them there at all?

@sbernauer sbernauer requested a review from adwk67 April 21, 2026 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maltesander maltesander Awaiting requested review from maltesander

@adwk67 adwk67 Awaiting requested review from adwk67

Requested changes must be addressed to merge this pull request.

Assignees

@sbernauer sbernauer

Labels

release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action. scheduled-for/26.7.0

Projects

Stackable Engineering
Status: Development: In Review

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sbernauer @adwk67